Alexarnoldy net app doc updates #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy/harvesterhci.io into alexarnoldy-NetApp-doc-updates
✅ Deploy Preview for harvester-home-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ibrokethecloud
requested review from
bk201,
ibrokethecloud and
jillian-maroket
|
The change removes the validated chart version with a variable? was that intentional? |
|
It's a good observation. Yes, that was intentional. My reasoning is that if we haven't validated any specific version, we should give the user the opportunity to select any version that is available in the repo. |
|
Hello @ibrokethecloud, Does this format need to be changed for this PR to be merged? There are much more important fixes in this PR that fix things that are actually broken. |
|
I have no issue with the format, the only item I'd fix is revert the change to original version we had tested it with. Looks like the search and replace has removed the version we actually tested it against.
|
|
Sounds good. I'll fix that this evening or early tomorrow.
…--Alex.
On Tue, Jan 14, 2025 at 4:11 PM Gaurav Mehta ***@***.***> wrote:
I have no issue with the format, the only item I'd fix is revert the
change to original version we had tested it with.
Looks like the search and replace has removed the version we actually
tested it against.
image.png (view on web)
<https://github.com/user-attachments/assets/605d454e-a958-4352-b671-bd3c4ec9309b>
—
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHERG6VPXI2T2VLDZLACGAT2KWRUZAVCNFSM6AAAAABS62PD4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJRGM2TOMZTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Best regards,
--Alex.
*Alex Arnoldy*
Global Solution Architect
*SUSE: Simplify, Modernize, Accelerate*
Pacific Time Zone, United States
mobile: 408.828.9797
email: ***@***.***
Certified Kubernetes Administrator: ID # LF-nizdo68ax6, exp. 07/2025
Certified Kubernetes Security Specialist: ID # LF-39lx9tcv3d, exp. 09/2026
HashiCorp Vault Certified Associate
SUSE Certified Administrator in SUSE NeuVector 5
|
|
Hi Gaurav,
I've updated the doc so the statement reads "This has been tested with
Harvester 1.2.0 and Trident v23.07.0."
…On Tue, Jan 14, 2025 at 4:24 PM Alex Arnoldy ***@***.***> wrote:
Sounds good. I'll fix that this evening or early tomorrow.
--Alex.
On Tue, Jan 14, 2025 at 4:11 PM Gaurav Mehta ***@***.***>
wrote:
> I have no issue with the format, the only item I'd fix is revert the
> change to original version we had tested it with.
>
> Looks like the search and replace has removed the version we actually
> tested it against.
>
> image.png (view on web)
> <https://github.com/user-attachments/assets/605d454e-a958-4352-b671-bd3c4ec9309b>
>
> —
> Reply to this email directly, view it on GitHub
> <#74 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHERG6VPXI2T2VLDZLACGAT2KWRUZAVCNFSM6AAAAABS62PD4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJRGM2TOMZTHE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
Best regards,
--Alex.
*Alex Arnoldy*
Global Solution Architect
*SUSE: Simplify, Modernize, Accelerate*
Pacific Time Zone, United States
mobile: 408.828.9797
email: ***@***.***
Certified Kubernetes Administrator: ID # LF-nizdo68ax6, exp. 07/2025
Certified Kubernetes Security Specialist: ID # LF-39lx9tcv3d, exp. 09/2026
HashiCorp Vault Certified Associate
SUSE Certified Administrator in SUSE NeuVector 5
--
Best regards,
--Alex.
*Alex Arnoldy*
Global Solution Architect
[image:
https://more.suse.com/rs/937-DCH-261/images/SUSECON25-Email-Signature.png?version=0]
*SUSE: Simplify, Modernize, Accelerate*
Pacific Time Zone, United States
mobile: 408.828.9797
email: ***@***.***
Certified Kubernetes Administrator: ID # LF-nizdo68ax6, exp. 07/2025
Certified Kubernetes Security Specialist: ID # LF-39lx9tcv3d, exp. 09/2026
HashiCorp Vault Certified Associate
SUSE Certified Administrator in SUSE NeuVector 5
|
bk201
approved these changes
Jan 16, 2025
jillian-maroket
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated this document to allow for newer software versions. I've also adjusted it to match the change in NetApp's chart and app version changes. Lastly, I've changed some of the parameters in the resources (e.g. the StorageClass) based on my own experiences.