-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security related best practices #62
Conversation
✅ Deploy Preview for harvester-home-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2468bff
to
4250845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks reasonable to me :-)
sorry @w13915984028 took me a while to get around to this. If we could please incorporate the feedback from @jillian-maroket then we can get this merged. |
4b18612
to
f8c9273
Compare
Signed-off-by: Jian Wang <jian.wang@suse.com>
Finally got time to update this PR: @jillian-maroket @ibrokethecloud please take another look, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks.
JIRA ticket SURE-8222
GH issue: TBD