Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security related best practices #62

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

w13915984028
Copy link
Member

JIRA ticket SURE-8222
GH issue: TBD

Copy link

netlify bot commented May 31, 2024

Deploy Preview for harvester-home-preview ready!

Name Link
🔨 Latest commit d462598
🔍 Latest deploy log https://app.netlify.com/sites/harvester-home-preview/deploys/667ac68bad3aa7000848a1c8
😎 Deploy Preview https://deploy-preview-62--harvester-home-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review done

kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
kb/2024-05-31/harvester_security_best_practice.md Outdated Show resolved Hide resolved
Copy link

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks reasonable to me :-)

@ibrokethecloud
Copy link
Contributor

sorry @w13915984028 took me a while to get around to this. If we could please incorporate the feedback from @jillian-maroket then we can get this merged.

@w13915984028 w13915984028 force-pushed the security branch 4 times, most recently from 4b18612 to f8c9273 Compare June 25, 2024 13:27
Signed-off-by: Jian Wang <jian.wang@suse.com>
@w13915984028
Copy link
Member Author

Finally got time to update this PR:
(1) All comments from @jillian-maroket, thanks
(2) Replace the create a Harvester cluster to install a Harvester cluster
(3) Update the reference to new setting auto-rotate-rke2-certs
(4) Add a new reference to GH issue
rke2 token rotate does not work as expected (v1.27.10+rke2r1)
...

@jillian-maroket @ibrokethecloud please take another look, thanks.

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@w13915984028 w13915984028 merged commit 2ca5001 into harvester:main Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants