-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KB: update the fstrim document with windows info #59
Conversation
✅ Deploy Preview for harvester-home-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8eea17b
to
a7769e3
Compare
|
||
- To disable TRIM operation on ReFS v2: | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent the code blocks for consistency. Check the preview: https://deploy-preview-59--harvester-home-preview.netlify.app/kb/the_potential_risk_with_fstrim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vicente-Cheng Let me know if you have concerns about the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
0561d85
to
c9a5ab5
Compare
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com> Co-authored-by: Kiefer Chang <kiefer.chang@suse.com> Co-authored-by: Jillian <cjmaroket@outlook.com>
c9a5ab5
to
541bdcc
Compare
Hi @bk201, @jillian-maroket, Sorry, I need your help to review this again. On the Windows system, we usually call trim or unmap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vicente-Cheng Most of the changes are fine. Just make sure that you use "filesystem trim" consistently. Check my comments.
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
Add the windows related info for how to check TRIM status