Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KB: update the fstrim document with windows info #59

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

Vicente-Cheng
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng commented Mar 26, 2024

Add the windows related info for how to check TRIM status

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for harvester-home-preview ready!

Name Link
🔨 Latest commit cf0677e
🔍 Latest deploy log https://app.netlify.com/sites/harvester-home-preview/deploys/66063c55f754f8000846dbf4
😎 Deploy Preview https://deploy-preview-59--harvester-home-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vicente-Cheng Vicente-Cheng force-pushed the add-windows-fstrim-info branch from 8eea17b to a7769e3 Compare March 26, 2024 09:22
@Vicente-Cheng Vicente-Cheng requested a review from bk201 March 26, 2024 09:54

- To disable TRIM operation on ReFS v2:
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vicente-Cheng Let me know if you have concerns about the changes.

kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Vicente-Cheng Vicente-Cheng marked this pull request as draft March 28, 2024 15:22
@Vicente-Cheng Vicente-Cheng force-pushed the add-windows-fstrim-info branch from 0561d85 to c9a5ab5 Compare March 28, 2024 16:17
@Vicente-Cheng Vicente-Cheng marked this pull request as ready for review March 28, 2024 16:17
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Co-authored-by: Kiefer Chang <kiefer.chang@suse.com>
Co-authored-by: Jillian <cjmaroket@outlook.com>
@Vicente-Cheng Vicente-Cheng force-pushed the add-windows-fstrim-info branch from c9a5ab5 to 541bdcc Compare March 28, 2024 16:18
@Vicente-Cheng
Copy link
Contributor Author

Hi @bk201, @jillian-maroket,

Sorry, I need your help to review this again.
fstrim is usually used on Linux systems because fstrim is the filesystem trim related command.

On the Windows system, we usually call trim or unmap.
So I do some updates to replace the fstrim with the filesystem trim.
Please help to recheck it, thanks!

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vicente-Cheng Most of the changes are fine. Just make sure that you use "filesystem trim" consistently. Check my comments.

kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
@bk201 bk201 merged commit ffa0c66 into harvester:main Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants