Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understanding Harvester Resource Metrics Calculation #52

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

w13915984028
Copy link
Member

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for harvester-home-preview ready!

Name Link
🔨 Latest commit e138197
🔍 Latest deploy log https://app.netlify.com/sites/harvester-home-preview/deploys/65b80c6f3a0fea0008fa05f7
😎 Deploy Preview https://deploy-preview-52--harvester-home-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w13915984028 The draft contained too many headings so I restructured the content and rewrote most of the descriptions to fit the new structure.

kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/reserved_resources_calculation.md Outdated Show resolved Hide resolved
@w13915984028 w13915984028 changed the title Understanding Harvester Reserved Resources Calculation Understanding Harvester Resource Metrics Calculation Jan 26, 2024
@w13915984028
Copy link
Member Author

@jillian-maroket Thanks all the suggestions, I also amend the document to harvester resource metrics calculation, not only the reserved resources calculation. Please take another look, thanks.

@w13915984028 w13915984028 requested a review from bk201 January 26, 2024 08:58
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w13915984028 I reviewed the new sentences.

kb/2024-01-23/harvester_resource_metrics_calculation.md Outdated Show resolved Hide resolved
kb/2024-01-23/harvester_resource_metrics_calculation.md Outdated Show resolved Hide resolved
Copy link
Contributor

@markhillgit markhillgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made one small suggestion at the beginning, but I approve. This looks good and meets the customer requirement, thank you.

kb/2024-01-23/harvester_resource_metrics_calculation.md Outdated Show resolved Hide resolved
Signed-off-by: Jian Wang <w13915984028@gmail.com>
@bk201 bk201 merged commit 27e6a70 into harvester:main Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants