Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE! PR template review #26

Open
wants to merge 2 commits into
base: dai-1sdai-listing
Choose a base branch
from
Open

Conversation

leonimella
Copy link
Collaborator

@leonimella leonimella commented Jan 10, 2025

Harmony Swap Token List

Token name: token_name

Requirements

  • Is .json well formated?
  • Does branch open well in https://tokenlists.org/? example: https://tokenlists.org/token-list?url=raw-tokenlist.json-url
    • Grab the raw tokenlist.json file URL from the pull request and replace it in the ?url= parameter above
  • Is the contract verified?
  • Does name, decimal and symbol data match contract data?
  • Is version incremented?
    • Check the version field of the proposed tokenlist.json file. If token is being added then bump in minor, if token is being edited then bump in patch
  • Is icon file present?
    • It's ok if the logo doesn't render in the proposed URL, but it has to be present in the PR

@leonimella leonimella changed the title DO NOT MERGE! PR template Review DO NOT MERGE! PR template review Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants