Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal Of Max Commission Change Per Day #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FortuneV13
Copy link
Contributor

@FortuneV13 FortuneV13 commented Nov 16, 2024

Since the Max Commission Change parameter cannot be modified on the blockchain and some validators mistakenly set it too high, it may be beneficial to remove this from the validator profile.

Future on chain ideas:
Change wont take affect for X days ( displayed on profile ) and to show it's going to change to X at epoch X.
-or-
Limit the changes to like 1 per year
-or-
Allow decreases to those statistics but block increasing. There should be no downside to being able to reduce this.

For now , while the statistic remains active on-chain, its removal from the validator page could help remove any damaging impact from validator progression. The current commission rate is the most critical statistic already present.

@mur-me
Copy link
Contributor

mur-me commented Nov 16, 2024

@sophoah let's discuss this with the team

@patrickmogul
Copy link

I think this is important information to keep up, but what are the actual rules on max-rate and max-change-rate on the blockchain? Are these locked forever at the initial rates?

Can those be modified if we modified some blockchain code? Could we allow these settings to only be lowered for example (no rasing to prevent scamming)?

@FortuneV13
Copy link
Contributor Author

FortuneV13 commented Nov 16, 2024

I think this is important information to keep up, but what are the actual rules on max-rate and max-change-rate on the blockchain? Are these locked forever at the initial rates?

Can those be modified if we modified some blockchain code? Could we allow these settings to only be lowered for example (no rasing to prevent scamming)?

I like this: The ability to lower the rates, max, max-change without issue but increasing can be blocked or with delay @sophoah .

In the case of Sentinel setting to 100% max change by mistake on creation but wanting to lower it to the mininum or ~10% like all others. I guess whats visible right now for most validators is 10% per day, so we are talking 10 days to get to 100% as far as the public is concerned. So 10-100% is rather irrlavent but creates a negtive stat to the public.

@sophoah
Copy link
Contributor

sophoah commented Nov 18, 2024

@patrickmogul @FortuneV13 we'll discuss that internally. Anything is possible, the challenge is to make sure the changes are not leading to any side effects

@sophoah
Copy link
Contributor

sophoah commented Nov 18, 2024

for this PR, i wouldn't remove it from the UI as it is a risks for the delegator not knowing what are the validator max-change-rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants