Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ketrew 3.0.0 by default #127

Merged
merged 2 commits into from
Dec 30, 2016
Merged

Use Ketrew 3.0.0 by default #127

merged 2 commits into from
Dec 30, 2016

Conversation

smondet
Copy link
Member

@smondet smondet commented Dec 22, 2016

This fixes #71 and is related to #121; the idea is that now there are Ketrew and
Biokepi branches (hence, Docker hub “tags”) that are well in sync.

Cf.:

I did one full run through the instructions with this disco.sh and all worked without any additional opam pin:

$ ketrew --version
3.0.0

@smondet
Use Ketrew 3.0.0 by default
3432811 
This fixes #71 and is related to #121; the idea is that now there are Ketrew and
Biokepi branches (hence, Docker hub “tags”) that are well in sync.

Cf.:

- <https://hub.docker.com/r/hammerlab/biokepi-run/builds/>, tag
  `docker-ketrew-300`, and
- <https://hub.docker.com/r/hammerlab/coclobas/builds/>, tag
  `with-ketrew-300`.

I did one full run through the instructions with this `disco.sh` and all worked
without any additional `opam pin`:

    $ ketrew --version
    3.0.0
@smondet
Copy link
Member Author

smondet commented Dec 22, 2016

oops

now there are Ketrew and Biokepi branches (hence, Docker hub “tags”)

I meant Biokepi and coclobas branches

@smondet
Remove useless opam pin (#71 & #121)
38cd370 
The pinning was anyways done far too late, i.e. while getting Epidisco.
@smondet smondet merged commit 38cd370 into master Dec 30, 2016
smondet added a commit that referenced this pull request Dec 30, 2016
@smondet
Merge PR #127 (@smondet, Ketrew 3.0.0 by default)
e95a038
@ihodes ihodes deleted the fix-ketrew-version branch January 25, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ihodes ihodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disco.sh does not really force Ketrew 3.0.0
2 participants
@smondet @ihodes