Fixing several bugs in Halide's AMX support #8350
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes and fixes a number of issues with Halide's current AMX support:
tiled_matmul_wrong_modulo.cpp
)tiled_matmul_wrong_layout.cpp
)4 / element_width
(tiled_matmul_wrong_tiling.cpp
,tiled_matmul_wrong_pattern.cpp
)tile_x=tile_y
always holds in the original testsNot yet addressed
Add
node in the matcher is ignored.