Drop locator #81
Draft
Drop locator #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratik
reviewed
May 7, 2024
contracts/drop-locator/src/msg.rs
Outdated
| pub details: ChainDetails, | ||
| } | ||
|
|
||
| #[cw_serde] |
There was a problem hiding this comment.
add
#[derive(QueryResponses)]
ratik
requested changes
May 7, 2024
ratik
reviewed
May 7, 2024
| add_chain.name.clone(), | ||
| &add_chain.details.clone(), | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
make simple for loop to avoid unwraps
albertandrejev
previously approved these changes
May 21, 2024
ratik
reviewed
May 22, 2024
| }); | ||
| it('Query factory instances', async () => { | ||
| const { locator } = context.contracts; | ||
| const res = [...(await locator.queryFactoryInstances())]; |
ratik
reviewed
May 22, 2024
| expect(res).toHaveLength(2); | ||
| for (const instance of res) { | ||
| expect(instance.addr).toHaveLength(66); | ||
| expect(instance.contracts.token_contract).toHaveLength(66); |
There was a problem hiding this comment.
can we compare with contracts addresses returned from corresponding factory?
There was a problem hiding this comment.
What do you mean? It's a result of query from factory
There was a problem hiding this comment.
I mean not just check contract address length but compare the result returned from the locator to the result returned from the corresponding factory
ratik
reviewed
May 22, 2024
contracts/locator/src/tests.rs
Outdated
| withdrawal_voucher_contract: String::from("withdrawal_voucher_contract2"), | ||
| withdrawal_manager_contract: String::from("withdrawal_manager_contract2"), | ||
| strategy_contract: String::from("strategy_contract2"), | ||
| validators_set_contract: String::from("validators_set_contract2"), |
There was a problem hiding this comment.
you can use "validators_set_contract2".to_string() next time
ratik
approved these changes
May 22, 2024
ratik
reviewed
Jun 3, 2024
| let matches: number = 0; | ||
| for (const factory of context.contracts.factories) { | ||
| const factoryState = await factory.queryState(); | ||
| for (let i = 0; i < res.length; i += 1) { |
There was a problem hiding this comment.
not a blocker. for(const instance of res) {
ratik
approved these changes
Jun 3, 2024
ratik
previously approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.