Issue/138 #150
Merged
Issue/138 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawn-c111
commented
Oct 8, 2024
| @@ -23,6 +23,7 @@ contract BigBang is ERC2771Context { | |||
| event Executed( | |||
| address indexed owner, | |||
| uint256 indexed topHatId, | |||
| uint256 indexed hatterHatId, | |||
There was a problem hiding this comment.
hats protocol の hatId の取得が大変そうだったため、 hatterHatId も topHatId とともに event で emit してみましたが、大丈夫でしょうか？
yawn-c111
commented
Oct 8, 2024
Comment on lines
+15
to
+17
| address[] shareHolders, | ||
| uint256[] allocations, | ||
| uint256 totalAllocation |
There was a problem hiding this comment.
役割や着用時間の重み計算後の値は、後で取得したり計算するのが大変そうだったため、event に追加してみたのですが、大丈夫でしょうか？
|
SplitCreator の HatsTimeFrameModule 経由で mintHat して woreTime を使用するテストが、今回の変更により修正が必要になったため、この部分のテストコードを修正することで、 woreTime 込みのテスト実装のタスクを完成させました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連イシュー
タスク
eventへの引数の追加