Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerA/Switch] Drastically improve accuracy of the right pad with horrific hacks #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PowerA/Switch] Drastically improve accuracy of the right pad with horrific hacks #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions Firmware/OpenSteamController/src/trackpad.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,18 +1272,51 @@ void trackpadGetLastXY(Trackpad trackpad, uint16_t* xLoc, uint16_t* yLoc) {
dividend += factor * adc_vals_y[idx];
divisor += adc_vals_y[idx];
factor += 100;
}
}

if (divisor) {
y_pos = dividend / divisor;
}
}

// Update outputs if finger was down (i.e. x_pos and y_pos are both valid)
if (x_pos > 0 && y_pos > 0) {
if (x_pos > 0 && y_pos > 0) {

// the entire input is offset by about 15 degrees or so
// here we try to compensate for those invalid values by just
// increasing/decreasing them to make it roughly accurate
bool left = x_pos > 600;
bool right = x_pos < 600;
bool over = y_pos > 300;

if (left) {
y_pos += (y_pos / 6);
if (y_pos > 600) {
y_pos = 600;
}
} else if (right) {
y_pos -= (y_pos / 5);
if (y_pos < 1) {
y_pos = 0;
}
}

if (over) {
x_pos -= (x_pos / 6);
if (x_pos < 1) {
x_pos = 0;
}
}

*xLoc = x_pos;
*yLoc = y_pos;
}
} else if (y_pos == -1) {
// there's a mysterious deadzone at the top of the pad,
// this edge-case seems to only be hit when that deadzone is hit.
// so; we work around the deadzone by just maxing the Y
*xLoc = x_pos;
*yLoc = TPAD_MAX_Y;
}
}

/**
Expand Down