Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons and main menu and active tabs #4098

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Jul 10, 2024

What

  • This PR updates the main menu display icons.
  • Additionally, it ensures that active tabs are visually distinguished.

Why

To align with the Opensight UI design.

References

GEA-588
GEA-618

Checklist

  • Tests

@daniele-mng daniele-mng requested review from a team as code owners July 10, 2024 14:12
@daniele-mng daniele-mng changed the base branch from main to opensight-ui July 10, 2024 14:12
Copy link

github-actions bot commented Jul 10, 2024

Conventional Commits Report

Type Number
Changed 1
Added 1

🚀 Conventional commits found.

@daniele-mng daniele-mng marked this pull request as draft July 19, 2024 11:40
@daniele-mng daniele-mng force-pushed the main-menu-icons-and-active-tabs branch from 56ecfae to 8edd5d5 Compare September 3, 2024 07:40
Copy link

github-actions bot commented Sep 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 72b96ae.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@daniele-mng daniele-mng marked this pull request as ready for review September 3, 2024 08:17
@daniele-mng daniele-mng force-pushed the main-menu-icons-and-active-tabs branch from a1f5c3a to 26379cf Compare September 3, 2024 08:25
@daniele-mng daniele-mng marked this pull request as draft September 3, 2024 09:15
@daniele-mng daniele-mng force-pushed the main-menu-icons-and-active-tabs branch 4 times, most recently from cfffdde to 680eef8 Compare September 3, 2024 14:09
@daniele-mng daniele-mng marked this pull request as ready for review September 4, 2024 06:52
@daniele-mng daniele-mng changed the title Main menu icons and active tabs Icons and main menu and active tabs Sep 5, 2024
a-h-abdelsalam
a-h-abdelsalam previously approved these changes Sep 5, 2024
@daniele-mng daniele-mng force-pushed the main-menu-icons-and-active-tabs branch 2 times, most recently from 016c8f8 to f1f98b6 Compare September 6, 2024 09:26
@daniele-mng daniele-mng force-pushed the main-menu-icons-and-active-tabs branch from f1f98b6 to e4d5981 Compare September 6, 2024 11:43
@daniele-mng daniele-mng force-pushed the main-menu-icons-and-active-tabs branch from e4d5981 to 72b96ae Compare September 6, 2024 11:53
@daniele-mng daniele-mng merged commit 299125a into opensight-ui Sep 6, 2024
7 of 8 checks passed
@daniele-mng daniele-mng deleted the main-menu-icons-and-active-tabs branch September 6, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants