Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(daffio): split daffio nav into separate docs and marketing components #3436

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat(daffio): split daffio nav into separate docs and marketing components #3436

wants to merge 4 commits into from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 14, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: daff.io @daffodil/daff.io label Jan 14, 2025
@xelaint xelaint requested a review from griest024 January 14, 2025 21:29
@xelaint xelaint requested review from a team as code owners January 14, 2025 21:29
@xelaint
Copy link
Member Author

xelaint commented Jan 14, 2025

Screen Shot 2025-01-14 at 4 22 04 PM Screen Shot 2025-01-14 at 4 21 56 PM

@griest024 Tried to get the sidebar-footer to show on desktop but couldn't figure out how the code works.

@griest024
Copy link
Member

I'll fix it tomorrow

@xelaint xelaint marked this pull request as draft January 14, 2025 21:47
@griest024 @xelaint
feat(daffio): split daffio nav into separate docs and marketing compo…
560ff20 
…nents

---------

Co-authored-by: xelaint <xelaint@gmail.com>
@griest024
Copy link
Member

@xelaint I've set the docs index sidebars to always show the footer component, it should be g2g now

@griest024 griest024 marked this pull request as ready for review January 15, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griest024 griest024 Awaiting requested review from griest024

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
package: daff.io @daffodil/daff.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xelaint @griest024