Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): update root status tokens to use value retrieved from daff-map-get function #3428

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 13, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

--daff-theme-warn: #{theming.daff-color(theming.$daff-bronze, 60)};
--daff-theme-success: #{theming.daff-color(theming.$daff-green, 60)};
--daff-theme-critical: #{theming.daff-color(theming.$daff-red, 60)};

These values are using fixed values retrieved directly from palette names. This means they're not variable depending on light or dark theme.

What is the new behavior?

Added variables that retrieves the color based on the configure theme status function.

$warn: core.daff-map-get($theme, warn);
$success: core.daff-map-get($theme, success);
$critical: core.daff-map-get($theme, critical);

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jan 13, 2025
@xelaint xelaint requested a review from a team as a code owner January 13, 2025 18:00
@xelaint xelaint merged commit f299a83 into develop Jan 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant