Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geography): in-memory collection does not exist #2610

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Nov 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

the geography in memory driver tries to access the countries via the request info collection field, which is empty

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: geography @daffodil/geography status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Nov 21, 2023
@griest024 griest024 self-assigned this Nov 21, 2023
@griest024 griest024 requested a review from a team as a code owner November 21, 2023 03:34
@griest024 griest024 force-pushed the fix/geography/driver/in-memory/collection-empty branch from 3d8943d to c0df698 Compare November 21, 2023 16:54
@griest024 griest024 merged commit d9bbcb6 into graycoreio:develop Nov 21, 2023
22 checks passed
@griest024 griest024 deleted the fix/geography/driver/in-memory/collection-empty branch November 21, 2023 17:16
@gray-bot gray-bot mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: geography @daffodil/geography status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant