Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product): improve default product factory field generation #2609

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Nov 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

DaffDefaultProductFactory now requires passing the image factory to construct. It is recommended to use DI to construct factories.

Other information

@griest024 griest024 added package: product @daffodil/product status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Nov 21, 2023
@griest024 griest024 self-assigned this Nov 21, 2023
@griest024 griest024 requested a review from a team as a code owner November 21, 2023 02:44
@griest024 griest024 force-pushed the feat/product/improve-factory branch from 6e774d1 to fae5d40 Compare November 21, 2023 16:54
@griest024 griest024 force-pushed the feat/product/improve-factory branch from 24f66e2 to 7f7dc58 Compare November 22, 2023 00:34
@griest024 griest024 merged commit 48f4ba0 into graycoreio:develop Nov 22, 2023
28 checks passed
@griest024 griest024 deleted the feat/product/improve-factory branch November 22, 2023 02:03
@gray-bot gray-bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: product @daffodil/product status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant