Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): clean up why pwa page styles #2603

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Nov 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Redundant styles on the why page page were added for IE 11 autoprefixer support.

Fixes: N/A

What is the new behavior?

Remove duplicate/unnecessary styles because we don't need IE11 support.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: daff.io @daffodil/daff.io label Nov 15, 2023
@xelaint xelaint requested review from a team as code owners November 15, 2023 22:05
@xelaint xelaint changed the title feat(daffio): clean up wwhy pwa page styles feat(daffio): clean up why pwa page styles Nov 15, 2023
@xelaint xelaint merged commit 4a90668 into develop Nov 16, 2023
7 checks passed
@gray-bot gray-bot mentioned this pull request Nov 16, 2023
@xelaint xelaint deleted the why-pwa-page-update branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant