-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): add toast component #2499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xelaint
added
help wanted
Extra attention is needed for this PR or issue
package: design
@daffodil/design
labels
Jul 12, 2023
xelaint
force-pushed
the
toast-component
branch
from
August 9, 2023 14:04
c9ea574
to
e9055f3
Compare
|
From a discussion between @xelaint and myself, we decide that the toast should not, by default, hand down "status" to its child buttons. |
|
|
xelaint
force-pushed
the
toast-component
branch
2 times, most recently
from
October 2, 2023 16:19
be5a1f3
to
e9937f9
Compare
xelaint
force-pushed
the
toast-component
branch
from
November 17, 2023 16:08
3071c7b
to
9265c3d
Compare
xelaint
force-pushed
the
toast-component
branch
2 times, most recently
from
November 21, 2023 17:53
9ae14ec
to
ba5593b
Compare
xelaint
force-pushed
the
toast-component
branch
from
November 27, 2023 15:57
871dd67
to
50006a1
Compare
xelaint
force-pushed
the
toast-component
branch
from
December 15, 2023 14:53
50006a1
to
22b8a80
Compare
@damienwebdev Need you to review the updates I made to the |
xelaint
force-pushed
the
toast-component
branch
from
December 20, 2023 15:49
ec1f75b
to
640346b
Compare
xelaint
force-pushed
the
toast-component
branch
from
January 2, 2024 22:07
640346b
to
6c35847
Compare
griest024
force-pushed
the
toast-component
branch
from
March 5, 2024 04:14
bcfd70c
to
330758e
Compare
griest024
approved these changes
Mar 5, 2024
griest024
added
status: awaiting merge
This PR has met all the requirements for merge and is waiting on an admin
and removed
status: awaiting review
This PR is awaiting review
labels
Mar 5, 2024
xelaint
removed
the
status: awaiting merge
This PR has met all the requirements for merge and is waiting on an admin
label
Mar 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
@daffodil/design
package is missing a toast component that can be used to display time-sensitive notifications that are related to application level information.Part of: #1948
What is the new behavior?
Toast component that is displayed at the top-level of the interface that is used to communicate time-sensitive notifications that are related to application level information.
TODO:
duration
workDaffToastHorizontalPosition
andDaffToastVerticalPosition
)Does this PR introduce a breaking change?
Other information