Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): implement external router in-memory driver #1843

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Sep 23, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Demo implements external router in-memory driver behavior. The resolver in the passed config searches the product and category backends for entities with matching URLs.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Relies on #1841, #1842, #1838

@griest024 griest024 added the package: demo @daffodil/demo label Sep 23, 2021
@griest024 griest024 requested review from a team as code owners September 23, 2021 23:41
@griest024 griest024 marked this pull request as draft September 23, 2021 23:41
@griest024 griest024 force-pushed the feat/demo/driver/in-memory/external-router-config branch from 1bb7a28 to 73aa183 Compare September 29, 2021 00:33
@griest024 griest024 marked this pull request as ready for review September 29, 2021 00:33
@griest024
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@griest024 griest024 marked this pull request as draft October 5, 2021 02:43
@griest024 griest024 force-pushed the feat/demo/driver/in-memory/external-router-config branch from fdffb09 to eb811e8 Compare October 5, 2021 02:45
@griest024 griest024 force-pushed the feat/demo/driver/in-memory/external-router-config branch from eb811e8 to a3f834e Compare November 24, 2023 18:01
@griest024 griest024 self-assigned this Nov 24, 2023
@griest024 griest024 added the status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin label Nov 24, 2023
@griest024 griest024 marked this pull request as ready for review November 24, 2023 18:01
@griest024 griest024 merged commit 669fe5a into graycoreio:develop Nov 24, 2023
7 checks passed
@gray-bot gray-bot mentioned this pull request Nov 24, 2023
@griest024 griest024 deleted the feat/demo/driver/in-memory/external-router-config branch November 24, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: demo @daffodil/demo status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant