Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(idp): support Oracle database for JDBC IdP #2654

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(idp): support Oracle database for JDBC IdP #2654

wants to merge 1 commit into from

Conversation

tcompiegne
Copy link
Member

@tcompiegne tcompiegne commented May 30, 2023 •
edited
Loading

Closes AM-586

@tcompiegne tcompiegne requested a review from a team as a code owner May 30, 2023 12:50
@tcompiegne tcompiegne force-pushed the AM-586-identity-provider-support-oracle-database-for-the-jdbc-id-p branch from f470b1d to c8bf3f5 Compare May 30, 2023 12:51
@tcompiegne tcompiegne changed the title --wip-- feat(idp): support Oracle database for JDBC IdP May 30, 2023
@tcompiegne tcompiegne force-pushed the AM-586-identity-provider-support-oracle-database-for-the-jdbc-id-p branch from c8bf3f5 to 50e0c33 Compare May 31, 2023 20:00
@tcompiegne tcompiegne marked this pull request as draft June 1, 2023 13:33
@tcompiegne tcompiegne force-pushed the AM-586-identity-provider-support-oracle-database-for-the-jdbc-id-p branch from 50e0c33 to ffbe159 Compare June 3, 2023 16:01
@tcompiegne tcompiegne marked this pull request as ready for review June 5, 2023 07:40
@tcompiegne tcompiegne changed the base branch from 3.21.x to master June 14, 2023 08:14
@tcompiegne tcompiegne force-pushed the AM-586-identity-provider-support-oracle-database-for-the-jdbc-id-p branch from ffbe159 to 9e634b2 Compare June 14, 2023 08:22
@tcompiegne tcompiegne force-pushed the AM-586-identity-provider-support-oracle-database-for-the-jdbc-id-p branch from 9e634b2 to a19f8f8 Compare June 14, 2023 08:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

leleueri
leleueri requested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@leleueri leleueri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition of the review comment, can you please solve conflict ?

...identityprovider/gravitee-am-identityprovider-jdbc/src/main/resources/database/oracle.schema
Comment on lines +6 to +7
CREATE TABLE idp_users___ (id NVARCHAR2(64) NOT NULL, username NVARCHAR2(320) NOT NULL, password NVARCHAR2(255) NULL, email NVARCHAR2(320) NULL, metadata CLOB NULL, PRIMARY KEY (id))
CREATE INDEX idp_users____username_idx ON users(username)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: username must be unique

@tcompiegne tcompiegne requested a review from a team as a code owner February 13, 2024 09:46
@leleueri leleueri marked this pull request as draft March 20, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leleueri leleueri leleueri requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status: on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcompiegne @leleueri