Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossplane - add missing selector and ref fields for various OnCall resources #4411

Closed
joeyorlando opened this issue May 28, 2024 · 4 comments · Fixed by grafana/crossplane-provider-grafana#158 or grafana/crossplane-provider-grafana#162
Assignees

Comments

@joeyorlando
Copy link
Contributor

What would you like to see!

Our Crossplane provider currently doesn't allow specifying a selector for an integration's default route's escalation chain (we only provide defaultRoute.escalationChainId). See our crossplane provider docs for more context.

See NotificationPolicy.contactPointRef as an example of ideally how we should do this.

Deliverables
As a user of Crossplane whom is trying to code-ify my OnCall Integrations, I should be able to have my Integration's default route escalation chain reference an Escalation Chain

Product Area

Terraform

Anything else to add?

No response

Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.5.1. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@MasterExecuson
Copy link

This issue actually affects other the On-Call components (Schedule, Route, Integration, Escalation) which also need crossreference from other resources.

@joeyorlando joeyorlando self-assigned this Jun 11, 2024
@joeyorlando joeyorlando changed the title Crossplane - I should be able to reference an escalation chain for the Integration.defaultRoute.escalationChain field Crossplane - add missing selector and ref fields for various OnCall resources Jun 13, 2024
@joeyorlando joeyorlando reopened this Jun 13, 2024
@joeyorlando
Copy link
Contributor Author

joeyorlando commented Jun 13, 2024

re-opened as we need to add selector and ref fields for a few more objects:

  • Integration (check that there are no other related fields)
  • Schedule
  • Route
  • Escalation

@MasterExecuson were they other objects you were using/came across that were missing selector/refs?

Once those changes are in, I'll go ahead and cut the v0.16.2 release over there

@MasterExecuson
Copy link

MasterExecuson commented Jun 13, 2024

@joeyorlando , find bellow the link for the fields that are reference through ID and thus don't work great on Crossplane after this first commit.

Escalation

NotifyOnCallFromSchedule

GroupToNotify

PersonsToNotifyNextEachTime

PersonsToNotify

NotifyToTeamMembers

Escalation Chain

TeamId

Integration

teamId

OnCallShift

RollingUsers

teamId

Route

Done.

Schedule

teamId

shifts

I know it's actually as lot of field, but without those, creating a crossplane config for on call is very hard and requires a lot of custom mapping (speaking from expirience)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment