-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finish adding ref
and selector
fields for all Grafana OnCall resources
#162
finish adding ref
and selector
fields for all Grafana OnCall resources
#162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 201
Lines ? 29392
Branches ? 0
======================================
Hits ? 0
Misses ? 29392
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@MasterExecuson see this PR. One thing to note is that for any related object which is only represented by a Terraform datasource (as opposed to a resource), Crossplane doesn't allow us to specify refs/selectors for these. Terraform datasources are not translated to Crossplane resources unfortunately. The workaround they have is this, basically using the Terraform provider for Crossplane to use the datasources directly. Once we get v0.17.0 of this provider published, let me know if you're able to get this working with the linked documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of your changes
Adds all missing
selector
andref
fields for the following Grafana OnCall Crossplane resources:oncall.grafana.crossplane.io.EscalationChain
oncall.grafana.crossplane.io.Escalation
oncall.grafana.crossplane.io.Integration
oncall.grafana.crossplane.io.OnCallShift
oncall.grafana.crossplane.io.OutgoingWebhook
oncall.grafana.crossplane.io.Route
oncall.grafana.crossplane.io.Schedule
Closes grafana/oncall#4411
I have:
make reviewable test
to ensure this PR is ready for review.