Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish adding ref and selector fields for all Grafana OnCall resources #162

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Jun 17, 2024

Description of your changes

Adds all missing selector and ref fields for the following Grafana OnCall Crossplane resources:

  • oncall.grafana.crossplane.io.EscalationChain
  • oncall.grafana.crossplane.io.Escalation
  • oncall.grafana.crossplane.io.Integration
  • oncall.grafana.crossplane.io.OnCallShift
  • oncall.grafana.crossplane.io.OutgoingWebhook
  • oncall.grafana.crossplane.io.Route
  • oncall.grafana.crossplane.io.Schedule

Closes grafana/oncall#4411

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

@joeyorlando joeyorlando requested a review from a team as a code owner June 17, 2024 17:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c5af3f9). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #162   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?     201           
  Lines           ?   29392           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?   29392           
  Partials        ?       0           
Flag Coverage Δ
unittests 0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeyorlando
Copy link
Contributor Author

@MasterExecuson see this PR.

One thing to note is that for any related object which is only represented by a Terraform datasource (as opposed to a resource), Crossplane doesn't allow us to specify refs/selectors for these. Terraform datasources are not translated to Crossplane resources unfortunately.

The workaround they have is this, basically using the Terraform provider for Crossplane to use the datasources directly.

Once we get v0.17.0 of this provider published, let me know if you're able to get this working with the linked documentation.

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienduchesne julienduchesne merged commit 803d418 into grafana:main Jun 18, 2024
8 checks passed
@joeyorlando joeyorlando deleted the jorlando/add-more-oncall-resource-selectors-and-refs branch June 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossplane - add missing selector and ref fields for various OnCall resources
3 participants