-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding Query Types for creating "Query Result" dashboard variables #190
Conversation
@Duologic @malcolmholmes requesting a review of this PR |
bump quick set of 👀 please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response, I have made one suggestion.
Would you mind also generating this for the libraries? See https://github.com/grafana/grafonnet/blob/main/CONTRIBUTING.md for instructions.
Co-authored-by: Jeroen Op 't Eynde <jeroen@simplistic.be>
@Duologic, thank you very much for the review, accepted your suggestion 👍🏼 Tried to run Is grafonnet locked down to use an older jsonnet version 🤔 , couldn't find a version reference in the repo. |
It is using the go-version of jsonnet, I think |
superseded by #206 |
so should the contributing docs be updated accordingly or the Makefile be updated for the docs to be "correct" 🤔 |
Overview
This PR expands the queryTypes to create "QueryResult" template variable in Grafana.
Changes
Querytype array has been extended to include QueryResult function.
Impact
This change will help users to use set dashboard variables of Query Type:
Query Result
.Issue: #191
Please review the changes and merge them if everything is in order.