Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding Query Types for creating "Query Result" dashboard variables #190

Closed
wants to merge 2 commits into from

Conversation

srikotu
Copy link
Contributor

@srikotu srikotu commented Apr 2, 2024

Overview

This PR expands the queryTypes to create "QueryResult" template variable in Grafana.

Changes

Querytype array has been extended to include QueryResult function.

Impact
This change will help users to use set dashboard variables of Query Type: Query Result.

Issue: #191
Please review the changes and merge them if everything is in order.

@srikotu srikotu requested a review from a team April 2, 2024 16:04
@srikotu
Copy link
Contributor Author

srikotu commented Apr 3, 2024

@Duologic @malcolmholmes requesting a review of this PR

@Duologic Duologic changed the title Enhancement: Expanding Query Types for creating "Query Result" dashboard variables Expanding Query Types for creating "Query Result" dashboard variables Apr 10, 2024
@srikotu
Copy link
Contributor Author

srikotu commented Apr 30, 2024

@Duologic @malcolmholmes requesting a review of this PR

bump quick set of 👀 please

Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, I have made one suggestion.

Would you mind also generating this for the libraries? See https://github.com/grafana/grafonnet/blob/main/CONTRIBUTING.md for instructions.

custom/dashboard/variable.libsonnet Outdated Show resolved Hide resolved
Co-authored-by: Jeroen Op 't Eynde <jeroen@simplistic.be>
@srikotu
Copy link
Contributor Author

srikotu commented May 13, 2024

@Duologic, thank you very much for the review, accepted your suggestion 👍🏼

Tried to run make -B generate 10.4.1 but it seems like the jsonnet commands in scripts/generate.sh are using older options like -c.

Is grafonnet locked down to use an older jsonnet version 🤔 , couldn't find a version reference in the repo.

@Duologic
Copy link
Member

It is using the go-version of jsonnet, I think -c is not supported on the C-version.

@Duologic
Copy link
Member

superseded by #206

@Duologic Duologic closed this May 28, 2024
@srikotu
Copy link
Contributor Author

srikotu commented May 28, 2024

It is using the go-version of jsonnet, I think -c is not supported on the C-version.

so should the contributing docs be updated accordingly or the Makefile be updated for the docs to be "correct" 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants