Fixed: Improve single place result handling and job completion #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugkerb
commented
Nov 26, 2024
bugkerb
commented
- Add delay when waiting for redirect URL to handle single place results
- Fix scrollbar detection for single result cases
- Add proper job completion handling with exit monitor
- Add delay when waiting for redirect URL to handle single place results - Fix scrollbar detection for single result cases - Add proper job completion handling with exit monitor
|
@bugkerb thanks for the PR. I haven't found the time to check yet. Will do the next days apologies for the delay |
|
do you mind fixing the linter error? https://github.com/gosom/google-maps-scraper/actions/runs/12029219575/job/34432880229#step:5:201 run locally with thank you very much for the PR |
This was referenced Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.