Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add suggestions and fixes #28

Merged
merged 6 commits into from
Dec 30, 2021
Merged

feat: add suggestions and fixes #28

merged 6 commits into from
Dec 30, 2021

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Dec 21, 2021

This provides fixes and suggestions for the existing rules. The fixes are not exhaustive and bail on complex usage.

service.getDetails({place_id: 'foo'})

becomes

service.getDetails({fields: /** TODO: Add necessary fields to the request */ [], place_id: 'foo'})

@jpoehnelt jpoehnelt changed the title feat: add suggestions for no-api-keys feat: add suggestions and fixes Dec 21, 2021
@jpoehnelt jpoehnelt requested a review from wangela December 22, 2021 00:02
README.md Outdated Show resolved Hide resolved
@jpoehnelt jpoehnelt requested a review from wangela December 22, 2021 17:04
@jpoehnelt jpoehnelt force-pushed the feat/no-api-keys-fixer branch from e4578a0 to c4ec1c5 Compare December 22, 2021 18:30
@jpoehnelt jpoehnelt merged commit 3e5740a into main Dec 30, 2021
@jpoehnelt jpoehnelt deleted the feat/no-api-keys-fixer branch December 30, 2021 19:32
github-actions bot pushed a commit that referenced this pull request Dec 30, 2021
## [1.4.0](v1.3.0...v1.4.0) (2021-12-30)

### Features

* add suggestions and fixes ([#28](#28)) ([3e5740a](3e5740a))

### Miscellaneous Chores

* **deps-dev:** bump @types/node from 17.0.2 to 17.0.4 ([#33](#33)) ([e0daf0f](e0daf0f))
* **deps-dev:** bump @types/node from 17.0.4 to 17.0.5 ([#34](#34)) ([bf6d3bf](bf6d3bf))
* **deps-dev:** bump @typescript-eslint/eslint-plugin ([#35](#35)) ([8cba839](8cba839))
* **deps-dev:** bump @typescript-eslint/parser from 5.8.0 to 5.8.1 ([#37](#37)) ([30f55d1](30f55d1))
* **deps-dev:** bump eslint-plugin-jest from 25.3.0 to 25.3.2 ([#38](#38)) ([d1a9ce2](d1a9ce2))
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants