Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for proto3 optional tag #2295

Merged
merged 1 commit into from
Oct 31, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,17 @@ private static ProtoSchema convertInternal(
enumTypes.add(enumFullName);
}
}
// The protobuf payload will be decoded as proto2 on the server side. The schema is also
// specified as proto2. Hence we must clear proto3-only features. This works since proto2 and
// proto3 are binary-compatible.
if (resultField.hasProto3Optional()) {
agrawal-siddharth marked this conversation as resolved.
Show resolved Hide resolved
// Clear proto3-only features
resultField.clearProto3Optional();
}
if (resultField.hasOneofIndex()) {
// Clear proto3-only features
resultField.clearOneofIndex();
}
resultProto.addField(resultField);
}
structTypes.add(protoFullName);
Expand Down
Loading