Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add PHP 8.4 compatibility to last release compatible with PHP 7.4 #592

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Dec 4, 2024

Ensures that the last google/auth release which was compatible with PHP 7.4 will be compatible with PHP 8.4 as well.

Once this is merged, we will tag this as v1.37.2

fixes #590

@bshaffer bshaffer requested a review from a team as a code owner December 4, 2024 20:37
@mikkamp
Copy link

mikkamp commented Dec 11, 2024

Thanks @bshaffer
We've tested using these branches with our extension in woocommerce/google-listings-and-ads#2714
Everything looks good and we no longer receive deprecation notices from this package.

@bshaffer bshaffer merged commit 25eed00 into 1.37.x Dec 11, 2024
13 checks passed
@bshaffer bshaffer deleted the 1.37.x-php84 branch December 11, 2024 18:15
@bshaffer
Copy link
Contributor Author

@mikkamp thanks for your review! I've tagged v1.37.2 with these changes, so this should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants