Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to manually include OSS licenses #212

Closed
wants to merge 2 commits into from
Closed

Add the ability to manually include OSS licenses #212

wants to merge 2 commits into from

Conversation

wseemann
Copy link

Hello, this is a great library! I noticed the oss-licenses-plugin didn't have the ability to add licenses manually so I added that functionality. To test this PR:

  1. Create custom_dependencies.json under res/raw
  2. Add entries any number of manual entries in the following JSON format:
[
  {
    "group": "",
    "version": "1.2.0",
    "fileLocation": "custom",
    "name": "Speex",
    "license": "https://www.speex.org/docs/manual/speex-manual/node15.html#sec:Speex-License"
  },
  {
    "group": "some.group",
    "version": "1.2.3",
    "fileLocation": "custom",
    "name": "Some Library",
    "license": "Some Text or URL"
  }
]
  1. Build and run the app like usual, enjoy

Let me know if you have any revisions!

@wseemann
Copy link
Author

FYI, I just filled out the Google CLA

@juliankotrba
Copy link

Hey @wseemann, just FYI, there is already a similar open PR for supporting third party licenses. However, the linked PR is already open for quite some time - still waiting for a maintainer's review. Fingers crossed that one the the PRs get merged anytime soon.

@wseemann
Copy link
Author

wseemann commented May 3, 2022

open PR

Thank you, I'm aware.

@wseemann
Copy link
Author

Closing out this MR due to inactivity.

@wseemann wseemann closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants