Skip to content

Commit

Permalink
[tint] Don't link 'benchmark_main' target
Browse files Browse the repository at this point in the history
Tint provides its own main().

Also add the benchmark target to the root BUILD.gn to have it built implicitly.

Change-Id: Iab254fde50f75e2ecd03c3b226883d2fb06c1585
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/154400
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
  • Loading branch information
ben-clayton authored and Dawn LUCI CQ committed Sep 30, 2023
1 parent ca6aea2 commit 089347a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 3 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ group("all") {
if (tint_build_unittests) {
deps += [ "src/tint/cmd/test:test_cmd" ]
}
if (tint_build_benchmarks) {
deps += [ "src/tint/cmd/bench:bench_cmd" ]
}
if (dawn_standalone) {
deps += [
"src/dawn/samples",
Expand Down
5 changes: 1 addition & 4 deletions src/tint/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,7 @@ if (tint_build_unittests) {
if (tint_build_benchmarks) {
group("google_benchmark") {
testonly = true
public_deps = [
"//third_party/google_benchmark",
"//third_party/google_benchmark:benchmark_main",
]
public_deps = [ "//third_party/google_benchmark" ]
}
}

Expand Down

0 comments on commit 089347a

Please sign in to comment.