Merge pull request #128 from gocardless/template-changes

Template changes

lib/gocardless_pro/client.rb

@@ -218,7 +218,7 @@ def default_options
           'User-Agent' => "#{user_agent}",
           'Content-Type' => 'application/json',
           'GoCardless-Client-Library' => 'gocardless-pro-ruby',
-          'GoCardless-Client-Version' => '2.54.0',
+          'GoCardless-Client-Version' => '2.55.0',
         },
       }
     end

lib/gocardless_pro/middlewares/raise_gocardless_errors.rb

@@ -3,9 +3,12 @@ module Middlewares
     class RaiseGoCardlessErrors < Faraday::Middleware
       API_ERROR_STATUSES = 501..599
       CLIENT_ERROR_STATUSES = 400..500
+      API_STATUS_NO_CONTENT = 204
 
       def on_complete(env)
-        raise ApiError, generate_error_data(env) if !json?(env) || API_ERROR_STATUSES.include?(env.status)
+        if !(env.status == API_STATUS_NO_CONTENT || json?(env)) || API_ERROR_STATUSES.include?(env.status)
+          raise ApiError, generate_error_data(env)
+        end
 
         return unless CLIENT_ERROR_STATUSES.include?(env.status)
 

lib/gocardless_pro/resources/subscription.rb

@@ -67,7 +67,6 @@ module Resources
     # last working day of the month).
     # - otherwise the charge date will be rolled __forwards__ to the next
     # business day.
-    #
     class Subscription
       attr_reader :amount
       attr_reader :app_fee

lib/gocardless_pro/services/bank_details_lookups_service.rb

@@ -13,6 +13,12 @@ class BankDetailsLookupsService < BaseService
       # Performs a bank details lookup. As part of the lookup, a modulus check and
       # reachability check are performed.
       #
+      # For UK-based bank accounts, where an account holder name is provided (and an
+      # account number, a sort code or an iban
+      # are already present), we verify that the account holder name and bank account
+      # number match the details held by
+      # the relevant bank.
+      #
       # If your request returns an [error](#api-usage-errors) or the
       # `available_debit_schemes`
       # attribute is an empty array, you will not be able to collect payments from the

lib/gocardless_pro/services/billing_requests_service.rb

@@ -110,6 +110,12 @@ def collect_customer_details(identity, options = {})
       # Direct Debit. If a bank account is discovered to be closed or invalid, the
       # customer is requested to adjust the account number/routing number and
       # succeed in this check to continue with the flow.
+      #
+      # _BACS scheme_ [Payer Name
+      # Verification](https://hub.gocardless.com/s/article/Introduction-to-Payer-Name-Verification?language=en_GB)
+      # is enabled by default for UK based bank accounts, meaning we verify the
+      # account holder name and bank account
+      # number match the details held by the relevant bank.
       # Example URL: /billing_requests/:identity/actions/collect_bank_account
       #
       # @param identity       # Unique identifier, beginning with "BRQ".

lib/gocardless_pro/services/subscriptions_service.rb

@@ -180,7 +180,6 @@ def update(identity, options = {})
       #
       # - `pause_cycles_must_be_greater_than_or_equal_to` if the provided value for
       # `pause_cycles` cannot be satisfied.
-      #
       # Example URL: /subscriptions/:identity/actions/pause
       #
       # @param identity       # Unique identifier, beginning with "SB".

lib/gocardless_pro/version.rb

@@ -3,5 +3,5 @@ module GoCardlessPro
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '2.54.0'
+  VERSION = '2.55.0'
 end