-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return error if userObject is not found #37
Open
Danielss89
wants to merge
5
commits into
goalio:master
Choose a base branch
from
Danielss89:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4679404
Return error if userObject is not found
Danielss89 2fe37ff
remove ServiceManagerAwareInterface
Danielss89 387882c
Use servicemanager directly
Danielss89 c6c38a7
Remove servicemanagerawareinterface
Danielss89 6331605
Remove servicemanagerawareinterface
Danielss89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
<?php | ||
namespace GoalioRememberMe; | ||
|
||
use GoalioRememberMe\Authentication\Adapter\Cookie; | ||
use Zend\Mvc\MvcEvent; | ||
use Zend\Http\Request as HttpRequest; | ||
use Zend\Loader\StandardAutoloader; | ||
|
@@ -26,12 +27,17 @@ public function getConfig() { | |
public function getServiceConfig() { | ||
return array( | ||
'invokables' => array( | ||
'GoalioRememberMe\Authentication\Adapter\Cookie' => 'GoalioRememberMe\Authentication\Adapter\Cookie', | ||
'GoalioRememberMe\Form\Login' => 'GoalioRememberMe\Form\Login', | ||
'goaliorememberme_rememberme_service' => 'GoalioRememberMe\Service\RememberMe', | ||
), | ||
), | ||
|
||
'factories' => array( | ||
'goaliorememberme_rememberme_service' => function ($sm) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the factories should move to separate file so we dion't break the caching of this. |
||
return new\GoalioRememberMe\Service\RememberMe($sm); | ||
}, | ||
|
||
'GoalioRememberMe\Authentication\Adapter\Cookie' => function ($sm) { | ||
return new Cookie($sm); | ||
}, | ||
|
||
'goaliorememberme_module_options' => function ($sm) { | ||
$config = $sm->get('Config'); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this the message needs to be an class constant as wel??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not in constants in the other cases, so it's not in the scope of this ticket to move it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
Let's merge this change