fix(stream): add netrc password to mask targets (#603)

go-vela · Sep 27, 2024 · 9828b2a · 9828b2a
1 parent 7ec1fe1
commit 9828b2a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/executor/linux/build.go b/executor/linux/build.go
@@ -504,6 +504,12 @@ func (c *client) ExecBuild(ctx context.Context) error {
 			continue
 		}
 
+		// add netrc to secrets for masking in logs
+		sec := &pipeline.StepSecret{
+			Target: "VELA_NETRC_PASSWORD",
+		}
+		_step.Secrets = append(_step.Secrets, sec)
+
 		// load any lazy secrets into the container environment
 		c.err = loadLazySecrets(c, _step)
 		if c.err != nil {

diff --git a/executor/linux/stage.go b/executor/linux/stage.go
@@ -151,6 +151,12 @@ func (c *client) ExecStage(ctx context.Context, s *pipeline.Stage, m *sync.Map)
 			continue
 		}
 
+		// add netrc to secrets for masking in logs
+		sec := &pipeline.StepSecret{
+			Target: "VELA_NETRC_PASSWORD",
+		}
+		_step.Secrets = append(_step.Secrets, sec)
+
 		// load any lazy secrets and inject them into container environment
 		err = loadLazySecrets(c, _step)
 		if err != nil {