upgrade safe protocol-kit and fix tooling #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying zodiac-pilot-connect with
|
| Latest commit: |
f3ae2b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d29474b.zodiac-pilot.pages.dev |
| Branch Preview URL: | https://fix-safe-prep.zodiac-pilot.pages.dev |
|
I knew there was a reason I added this :D Let's see. If I can't get it to work without |
frontendphil
force-pushed
the
fix-safe-prep
branch
from
99bfc4e to
c6ea196
Compare
|
I've opened up a PR at safe-global/safe-core-sdk#1022 to fix the build of |
|
I opened another PR that takes a bigger stab at the setup for the whole repo: safe-global/safe-core-sdk#1047 |
frontendphil
force-pushed
the
fix-safe-prep
branch
from
dbfd6d5 to
fa1ba58
Compare
frontendphil
force-pushed
the
fix-safe-prep
branch
from
fa1ba58 to
9e4e50f
Compare
|
I'm merging this PR. Turns out I need the changes in it already and also we've done good so that it "just works". |
frontendphil
added a commit
that referenced
this pull request
Nov 26, 2024
* upgrade safe protocol-kit and fix tooling * ignore ts error * fix eslint issue * fix cspell * moah esm * fix types --------- Co-authored-by: Jan-Felix <jfschwarz@users.noreply.github.com> Co-authored-by: Philipp Giese <giese.philipp+git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the TS error is due to a bug in protocol-kit, I think -> safe-global/safe-core-sdk#1021
@frontendphil can you check if you can get e2e tests running without
"type": "module"in some way? 🙏