Ensure all config vars are present #20
Conversation
| # `MIN_VALIDATOR_WITHDRAWABILITY_DELAY + CHURN_LIMIT_QUOTIENT // 2` (= 33024, ~5 months) | ||
| MIN_EPOCHS_FOR_BLOCK_REQUESTS: 33024 |
There was a problem hiding this comment.
This used to be 2304 before this PR. Intended change? The new number does not match the comment anymore.
There was a problem hiding this comment.
Actually, it was 33024 already before (inherited from the preset). But the comment still is wrong and suggests 2304.
There was a problem hiding this comment.
Fixed it in Nimbus. Because config.yaml didn't specify it, we defaulted to 2304 based on the computation in the comment.
There was a problem hiding this comment.
The variable MIN_EPOCHS_FOR_BLOCK_REQUESTS was not defined in the config before this change. It was added 6 months ago in Ethereum's config on a effort to define network variables ethereum/consensus-specs@f87e143
Thanks for noticing, does Nimbus prune blocks according to MIN_EPOCHS_FOR_BLOCK_REQUESTS?
Add CI step to ensure gnosis config declares all config variables from an upstream Ethereum mainnet config