Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix possible issue regarding bytes/str decoding #1756

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

LeiGlobus
Copy link
Contributor

This started giving the following mypy error recently. Not quite sure what changed, but handling str vs. bytes formally is better anyway. (line a bit long for a one-liner so split it into if/else)

globus_compute_endpoint/engines/high_throughput/messages.py:110: error: If x = b'abc' then f"{x}" or "{}".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"{x!r}" or "{!r}".format(x). Otherwise, decode the bytes  [str-bytes-safe]

@LeiGlobus LeiGlobus added no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy labels Jan 9, 2025
@LeiGlobus LeiGlobus merged commit 52d15e4 into main Jan 9, 2025
21 checks passed
@LeiGlobus LeiGlobus deleted the fix_task_info_mypy branch January 9, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants