Increase max timeout in smoke tests to avoid tutorial endpoint slowness #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiGlobus
added
no-news-is-good-news
LeiGlobus
requested review from
yadudoc,
ryanchard,
chris-janidlo,
rjmello and
khk-globus
ryanchard
previously approved these changes
Jan 8, 2025
LeiGlobus
force-pushed
the
increase_smoke_test_timeout
branch
5 times, most recently
from
7df6f61 to
7552be0
Compare
LeiGlobus
force-pushed
the
increase_smoke_test_timeout
branch
from
7552be0 to
c1986b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the smoke tests are still failing. This might have been expected as we didn't increase the timeout much, just the retry backoff method.
Replicated this locally fairly easily. It's debatable how long we should wait before an actual error, but I don't think a larger number will hide 'real' issues much.
I ran tests 4 times with the new value successfully (with pauses in between to let the EP 'cool down').