-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add general config documentation #1721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
the
no-news-is-good-news
This change does not require a news file
label
Nov 14, 2024
khk-globus
requested review from
yadudoc,
ryanchard,
chris-janidlo,
rjmello and
LeiGlobus
November 14, 2024 20:07
khk-globus
added a commit
that referenced
this pull request
Nov 14, 2024
We have plenty of examples of known working configurations. But what we don't currently have is exhaustive documentation on what the YAML files support. Start to address that oversight.
khk-globus
force-pushed
the
add_config_documentation
branch
from
November 14, 2024 20:08
ca818ac
to
449cced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per Kevin's request, here are my current pending comments. will post again if I run into any more
khk-globus
added a commit
that referenced
this pull request
Nov 14, 2024
We have plenty of examples of known working configurations. But what we don't currently have is exhaustive documentation on what the YAML files support. Start to address that oversight.
khk-globus
force-pushed
the
add_config_documentation
branch
from
November 14, 2024 21:44
449cced
to
0f021aa
Compare
chris-janidlo
previously approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✍️ 🔥
yadudoc
reviewed
Nov 14, 2024
yadudoc
reviewed
Nov 14, 2024
yadudoc
reviewed
Nov 14, 2024
yadudoc
reviewed
Nov 14, 2024
We have plenty of examples of known working configurations. But what we don't currently have is exhaustive documentation on what the YAML files support. Start to address that oversight.
khk-globus
force-pushed
the
add_config_documentation
branch
from
November 14, 2024 22:43
0f021aa
to
8e61a14
Compare
yadudoc
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have plenty of examples of known working configurations. But what we don't currently have is exhaustive documentation on what the YAML files support. Start to address that oversight.
Reviewer reminder: one can build the docs by invoking
docs/autobuild.sh
, which also starts a local-only web server to serve them.Type of change