Update execute_task signature #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
the
no-news-is-good-news
khk-globus
requested review from
yadudoc,
chris-janidlo,
rjmello and
LeiGlobus
khk-globus
changed the title
yadudoc
reviewed
Nov 13, 2024
khk-globus
added a commit
that referenced
this pull request
Nov 13, 2024
`run_dir` is not optional; in a previous commit, it was enforced by an inline check. Update the function signature to match that requirement. While here, test the addition, and also bolster the module's tests in general.
khk-globus
force-pushed
the
update_execute_task_signature
branch
from
d37e03f to
fbd60e2
Compare
`run_dir` is not optional; in a previous commit, it was enforced by an inline check. Update the function signature to match that requirement. While here, test the addition, and also bolster the module's tests in general.
khk-globus
force-pushed
the
update_execute_task_signature
branch
from
fbd60e2 to
6fcdc08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_diris not optional; in a previous commit, it was enforced by an inline check. Update the function signature to match that requirement.While here, test the addition, and also bolster the module's tests in general.
Type of change