Move test task kernel to utils #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `divide` to utils, and remove the recently unreferenced `div_zero`. While here, make the test slightly more honest by using random numbers.
khk-globus
added
no-news-is-good-news
khk-globus
requested review from
yadudoc,
chris-janidlo,
rjmello and
LeiGlobus
khk-globus
changed the title
yadudoc
approved these changes
Nov 13, 2024
khk-globus
added a commit
that referenced
this pull request
Nov 13, 2024
Ensure deprecation is always warned, and simultaneously remove some unnecessary test output clutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
divideto utils, and remove the recently unreferenceddiv_zero. While here, make the test slightly more honest by using random numbers.Type of change