Move result size check one level higher #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
no-news-is-good-news
khk-globus
requested review from
yadudoc,
chris-janidlo,
rjmello and
LeiGlobus
No functional change but move result length check one level higher in the call stack. There's no sense in passing the size limit. `_call_user_function`'s purview is to invoke the function. Checking the result validity is for the higher-level helper. While in `_call_user_function`, make IDE slightly happier by not shadowing the module variable.
khk-globus
force-pushed
the
minor_execute_task_refactor
branch
from
355c9a6 to
c641420
Compare
yadudoc
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change but move result length check one level higher in the call stack. There's no sense in passing the size limit.
_call_user_function's purview is to invoke the function. Checking the result validity is for the higher-level helper.While in
_call_user_function, make IDE slightly happier by not shadowing the module variable.Type of change