Fixup a flaky test setup #1703
Merged
Fixup a flaky test setup #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that infrastructure is in place before we let the tests poke at it. The flakiness is a very rare occurrence -- I've only encountered it once, recently -- but flaky == no good.
khk-globus
added
no-news-is-good-news
LeiGlobus
approved these changes
Nov 4, 2024
|
I was thinking less the "wait in increments" and more like "the tests assume this is exists, so we wait until this is in place." I had made the try* methods (following Qt's implementation of similar in their test framework) a couple of years ago, so they were easily at-hand to solve this. If there's a better way ... do let me know! |
rjmello
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that infrastructure is in place before we let the tests poke at it. The flakiness is a very rare occurrence — I've only encountered it once, recently — but flaky == no good.
Type of change