-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move self diagnostic mostly to the SDK side and add more compatibilit… #1658
Conversation
30a4aa8
to
5c576cd
Compare
5c576cd
to
b926067
Compare
8c5d88e
to
fb7baec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a rebase is in progress. I'll continue when that's all done. Meanwhile, "comments in progress" as well! 😉
compute_endpoint/globus_compute_endpoint/endpoint/endpoint_manager.py
Outdated
Show resolved
Hide resolved
compute_endpoint/globus_compute_endpoint/endpoint/endpoint_manager.py
Outdated
Show resolved
Hide resolved
006e6f5
to
08a3db9
Compare
compute_endpoint/globus_compute_endpoint/endpoint/endpoint_manager.py
Outdated
Show resolved
Hide resolved
08a3db9
to
6be0681
Compare
122cf7e
to
d6563e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good; a few minor comments. Reid has already brought up the items of any importance that stood out to me, so you two go ahead.
Beyond those, I do wonder if the default output should be minimal, along the lines of what was globus-compute-endpoint self-diagnostic -z
. Right now, there's a bunch of header information for each test, which I'm thinking is largely superfluous for most users. Just the file is all that's necessary, and makes it similarly easier to reference, show, and request of users in #help. Perhaps adding -v/--verbose
to emit these headers instead?
Meanwhile, I observe that at least one test appears to fail when it it's not obvious to me that it should:
$ ll /etc/os-release
lrwxrwxrwx 1 root root 21 Sep 10 07:18 /etc/os-release -> ../usr/lib/os-release
$ globus-compute-diagnostic
...
== Diagnostic: python:cat(/etc/os-release) ==
No file named -
...
But generally, I'm looking forward to getting this out -- it's a nice addition!
""" | ||
Some following tests previously used fakefs, which apparently is no longer | ||
compatible with the new structure with lower level system calls. See: | ||
|
||
https://stackoverflow.com/questions/75789398/how-to-use-pyfakefs-pytest-to-test-a-function-using-multiprocessing-queue-via # noqa | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm; this begins to imply to me that these are no longer unit tests then. Crossing the process barrier is one indication of that. Semantic, perhaps, but I wonder if we can mock an appropriate something else, fixture-ize it, or do we move these tests?
On the other hand, I'm not looking too hard at this particular test file at the moment, so I may be missing something more fundamentally obvious.
497b1ef
to
2d2152c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is nearing the stage of bike-shedding; I'm ready to have this go in. @rjmello ?
Note that sometimes one of the executor tests (such as |
199836c
to
7aaa2ee
Compare
…y for multiple platforms
db64f91
to
be324ac
Compare
This refactors the endpoint specific self-diagnostic command into an executable script that is installed with the SDK.
The new self-diagnostic syntax examples: