Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy 1.6.1 got a little smarter / picky #1341

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Mypy 1.6.1 got a little smarter / picky #1341

merged 1 commit into from
Oct 26, 2023

Conversation

khk-globus
Copy link
Contributor

So remove a workaround we had implemented previously

Type of change

  • Bug fix (non-breaking change that fixes an issue)

So remove a workaround we had implemented previously
@khk-globus khk-globus added no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy labels Oct 26, 2023
Copy link
Contributor

@LeiGlobus LeiGlobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I was running into these issues as well. Thanks for getting to it faster.

@khk-globus khk-globus merged commit 5895588 into main Oct 26, 2023
30 checks passed
@khk-globus khk-globus deleted the address_mypy branch October 26, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-news-is-good-news This change does not require a news file quick-review Review of this should be quick and easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants