Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass heartbeat_period to Parsl HTEX #1338

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Pass heartbeat_period to Parsl HTEX #1338

merged 1 commit into from
Oct 25, 2023

Conversation

rjmello
Copy link
Member

@rjmello rjmello commented Oct 24, 2023

Description

The GlobusComputeEngine now passes the heartbeat_period argument to its Parsl HighThroughputExecutor.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

@rjmello rjmello force-pushed the gcengine-executor-heartbeat branch from 34b250f to f4d633b Compare October 25, 2023 03:16
yadudoc
yadudoc previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Looks good to go. Would be good to update that timeout before we merge so that the updated test is stable.

compute_endpoint/tests/unit/test_status_reporting.py Outdated Show resolved Hide resolved
@rjmello rjmello force-pushed the gcengine-executor-heartbeat branch from f4d633b to b38b366 Compare October 25, 2023 15:52
@rjmello rjmello requested a review from yadudoc October 25, 2023 15:52
yadudoc
yadudoc approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rjmello rjmello merged commit e438d0f into main Oct 25, 2023
30 checks passed
@rjmello rjmello deleted the gcengine-executor-heartbeat branch October 25, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khk-globus khk-globus khk-globus left review comments

@yadudoc yadudoc yadudoc approved these changes

@ryanchard ryanchard Awaiting requested review from ryanchard

@chris-janidlo chris-janidlo Awaiting requested review from chris-janidlo

@joshbryan-globus joshbryan-globus Awaiting requested review from joshbryan-globus

@LeiGlobus LeiGlobus Awaiting requested review from LeiGlobus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjmello @yadudoc @khk-globus