Change heartbeat_period type from float to int
#1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmello
requested review from
yadudoc,
ryanchard,
chris-janidlo,
joshbryan-globus,
khk-globus and
LeiGlobus
yadudoc
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
@rjmello and I had a discussion on this. We cannot use the float type for heartbeat_period until Parsl's HTEX is updated to use subsecond heartbeats. Without that support, keeping the float type doesn't help. Originally I wanted floats to help tests go faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
heartbeat_periodtype from float to int forGlobusComputeEngine,ProcessPoolEngine, andThreadPoolEngineto maintain parity with theHighThroughputEngineand Parsl'sHighThroughputExecutor.Type of change