-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alternative AMQP ports #1331
Conversation
This pull request has been linked to Shortcut Story #27144: Support configuring an endpoint to use AMQPS over 443. |
de536f0
to
2ad2038
Compare
@khk-globus brought up some good use-cases for ports that are outside of what the web service supports, so I dropped the code that restricts ports in favor of just documenting which ones we support. (Still need to verify that the ones mentioned in the docs here are accurate.) |
2ad2038
to
5ddc33b
Compare
compute_endpoint/globus_compute_endpoint/endpoint/config/config.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it would be easier to modify just the initial connection string? That is, when we receive the URL, do the urlparse()
/urlunparse()
dance. That would avoid the need to change any of the code in rabbit_mq/
, interchange.py
, or executor.py
.
5ddc33b
to
3833aac
Compare
3833aac
to
f0ab115
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo woo!
Description
[sc-27144]
Fixes # (issue)
Type of change