Support Globus auth policies on endpoints #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #26335: Support Auth Policies on Endpoints. |
rjmello
force-pushed
the
sc-26335/auth-policies
branch
from
df526c1 to
1986ca0
Compare
rjmello
requested review from
yadudoc,
ryanchard,
chris-janidlo,
joshbryan-globus,
khk-globus and
LeiGlobus
joshbryan-globus
previously approved these changes
Oct 10, 2023
There was a problem hiding this comment.
LGTM
Depending on how soon we get support for creating auth policies in the webapp, we may want to eventually add in some helper functions to be able to create an appropriate auth policy when you configure the endpoint (e.g. --allowed_domains etc.) But that can be a separate story later.
kurtmckee
suggested changes
Oct 10, 2023
Endpoint admins can now define a Globus authentication policy to evaluate endpoint users against. The web service handles both evaluation and enforcement.
rjmello
force-pushed
the
sc-26335/auth-policies
branch
from
1986ca0 to
a1c5906
Compare
kurtmckee
approved these changes
Oct 11, 2023
joshbryan-globus
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Endpoint admins can now define a Globus authentication policy directly in an endpoint's configuration or by using the
--auth-policyflag when running theglobus-compute-endpoint configurecommand.Users are evaluated against the policy when submitting tasks, retrieving endpoint information, etc. The Globus Compute web service handles both evaluation and enforcement (see https://github.com/globusonline/funcx-services/pull/501).
[sc-26335]
Type of change