Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-authentication-to-github.md #35776

Closed
wants to merge 1 commit into from
Closed

Conversation

akoper
Copy link

@akoper akoper commented Dec 27, 2024

Improve grammar and readability: sentence has parallel structure and removes duplicative articles.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

Improve grammar and readability: sentence has parallel structure and removes duplicative articles.
Copy link

welcome bot commented Dec 27, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 27, 2024
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/keeping-your-account-and-data-secure/about-authentication-to-github.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

nguyenalex836
nguyenalex836 previously approved these changes Dec 27, 2024
@nguyenalex836 nguyenalex836 self-requested a review December 27, 2024 14:20
@nguyenalex836 nguyenalex836 removed their request for review December 27, 2024 14:22
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Dec 27, 2024
@nguyenalex836
Copy link
Contributor

@akoper Thank you for raising this PR and your willingness to contribute! ✨ However, as these changes are mainly personal preferences on how to phrase something rather than corrections or improvements, I'm afraid we aren't able to accept this contribution 🙇

If you'd like to make changes I'd recommend raising an improvement issue here, then someone from the team can take a look at your proposal before you go ahead.

For more information about contributing, and our house style, see https://docs.github.com/en/contributing 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants