Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automatically-redelivering-failed-deliveries-for-a-github-app-webhook.md #35605

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

beliaev-maksim
Copy link
Contributor

@beliaev-maksim beliaev-maksim commented Dec 10, 2024

The octokit package has been updated to an ES Module. As a result, user needs adjust the script for ES Module compatibility, and convert the file to use the ES Module format. As part of this PR we also bump NodeJS version as 18 is soon EOL

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

…webhook.md

Update NodeJS version and modify script to be compatible with ES Module structure
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
webhooks/using-webhooks/automatically-redelivering-failed-deliveries-for-a-github-app-webhook.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks labels Dec 10, 2024
@nguyenalex836
Copy link
Contributor

@beliaev-maksim Thanks so much for opening a PR! I'll get this triaged for review ✨

Saeidhavashem

This comment was marked as spam.

Saeidhavashem

This comment was marked as off-topic.

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Dec 11, 2024
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Dec 12, 2024
Jano1141

This comment was marked as spam.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me from the @octokit JS SDK prespective. Thank you Maksim, Grüße nach Berlin 🐻

@beliaev-maksim
Copy link
Contributor Author

Changes look good to me from the @octokit JS SDK prespective. Thank you Maksim, Grüße nach Berlin 🐻

Thank you for the review!

@nguyenalex836
Copy link
Contributor

@beliaev-maksim Thanks again for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into github:main with commit dd98f14 Dec 20, 2024
45 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@beliaev-maksim beliaev-maksim deleted the patch-1 branch December 20, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants