Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Enable GitAuto to analyze images in GitHub issue body and comments and add the feedback to the issue and 2. Stop skipping check run review in dev env #396

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

hiroshinishio
Copy link
Collaborator

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hiroshinishio - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add parentheses to clarify the operator precedence in the condition. Is it intended as (product_id is None) or (product_id == STRIPE_PRODUCT_ID_FREE and IS_PRD) or (product_id is None or product_id == STRIPE_PRODUCT_ID_FREE) and IS_PRD?
  • Could you provide more context about why check run reviews should now be processed for free tier users in non-production environments?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hiroshinishio hiroshinishio changed the title Stop skipping check run review in dev env 1. Enable GitAuto to analyze images in GitHub issue body and comments and add the feedback to the issue and 2. Stop skipping check run review in dev env Dec 14, 2024
@hiroshinishio hiroshinishio merged commit 702f9cd into main Dec 14, 2024
2 checks passed
@hiroshinishio hiroshinishio deleted the wes branch December 14, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant